Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable blobtest again #4139

Merged
merged 1 commit into from
Aug 10, 2023
Merged

chore: enable blobtest again #4139

merged 1 commit into from
Aug 10, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 10, 2023

we have blob tx type now

@mattsse mattsse requested a review from gakonst as a code owner August 10, 2023 11:16
@mattsse mattsse added the C-test A change that impacts how or what we test label Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #4139 (a0401a0) into main (072c840) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

see 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.85% <ø> (-0.04%) ⬇️
unit-tests 64.06% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.94% <ø> (ø)
blockchain tree 82.83% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.75% <ø> (ø)
trie 94.71% <ø> (ø)
txpool 47.66% <ø> (ø)
networking 77.68% <ø> (-0.09%) ⬇️
rpc 58.70% <ø> (+0.01%) ⬆️
consensus 63.76% <ø> (ø)
revm 32.26% <ø> (ø)
payload builder 6.57% <ø> (ø)
primitives 87.91% <ø> (ø)

@mattsse mattsse requested a review from joshieDo August 10, 2023 11:29
@mattsse mattsse added this pull request to the merge queue Aug 10, 2023
Merged via the queue into main with commit 499ca3d Aug 10, 2023
24 checks passed
@mattsse mattsse deleted the matt/enable-blob-tests branch August 10, 2023 13:08
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
@mattsse @alessandromazza98
chore: enable blobtest again (paradigmxyz#4139)
70faa09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshieDo joshieDo joshieDo approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @joshieDo