Signature functions moved to rpc_types_compat

[supernovahs]

Ref #3964

TODO

• fmt

[codecov]

Codecov Report

Merging #4143 (98cae67) into main (072c840) will decrease coverage by 0.02%.
Report is 4 commits behind head on main.
The diff coverage is 0.00%.

Files Changed	Coverage Δ
crates/rpc/rpc-types-compat/src/transaction/mod.rs	0.00% <0.00%> (ø)
.../rpc/rpc-types-compat/src/transaction/signature.rs	0.00% <0.00%> (ø)
crates/rpc/rpc-types/src/eth/transaction/mod.rs	100.00% <ø> (ø)
...tes/rpc/rpc-types/src/eth/transaction/signature.rs	100.00% <ø> (+17.72%)	⬆️

... and 10 files with indirect coverage changes

Flag	Coverage Δ
integration-tests	16.86% <0.00%> (-0.02%)	⬇️
unit-tests	64.07% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
reth binary	25.94% <ø> (ø)
blockchain tree	82.83% <ø> (ø)
pipeline	90.07% <ø> (ø)
storage (db)	74.75% <ø> (ø)
trie	94.71% <ø> (ø)
txpool	47.66% <ø> (ø)
networking	77.69% <ø> (-0.08%)	⬇️
rpc	58.69% <0.00%> (+<0.01%)	⬆️
consensus	63.76% <ø> (ø)
revm	32.26% <ø> (ø)
payload builder	6.57% <ø> (ø)
primitives	87.91% <ø> (ø)

[mattsse]

can you try installing nightly toolchain and run

cargo +nightly fmt

https://rust-lang.github.io/rustup/installation/index.html#installing-nightly

[supernovahs]

I get this

supernovahs@supernova reth % rustup toolchain list
stable-aarch64-apple-darwin (default)
nightly-aarch64-apple-darwin (override)
supernovahs@supernova reth % cargo +nightly fmt   
error: no such command: `+nightly`

	Cargo does not handle `+toolchain` directives.
	Did you mean to invoke `cargo` through `rustup` instead?
supernovahs@supernova reth % 

[supernovahs]

It worked finally. There was a problem in my path environment variable.
This command worked

export PATH="$HOME/.cargo/bin:$PATH"

[mattsse]

lgtm, pending unused imports