Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(txpool): Make TransactionPool trait object safe #4156

Merged

Conversation

PatStiles
Copy link
Contributor

closes #4097

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #4156 (d953363) into main (500b0fa) will decrease coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 41.17%.

Impacted file tree graph

Files Changed Coverage Δ
crates/consensus/auto-seal/src/task.rs 0.00% <0.00%> (ø)
crates/net/network/src/transactions.rs 61.57% <0.00%> (+0.17%) ⬆️
crates/transaction-pool/src/noop.rs 12.85% <0.00%> (+0.26%) ⬆️
crates/transaction-pool/src/traits.rs 9.09% <ø> (ø)
crates/transaction-pool/src/lib.rs 42.07% <50.00%> (-1.05%) ⬇️
crates/transaction-pool/src/pool/mod.rs 48.61% <50.00%> (ø)
crates/transaction-pool/src/pool/txpool.rs 59.38% <83.33%> (ø)

... and 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.87% <5.88%> (-0.01%) ⬇️
unit-tests 64.04% <41.17%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.94% <ø> (ø)
blockchain tree 82.83% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.75% <ø> (ø)
trie 94.67% <ø> (-0.05%) ⬇️
txpool 47.59% <58.33%> (-0.64%) ⬇️
networking 77.75% <0.00%> (-0.03%) ⬇️
rpc 58.69% <ø> (-0.01%) ⬇️
consensus 63.73% <0.00%> (-0.04%) ⬇️
revm 32.18% <ø> (ø)
payload builder 6.57% <ø> (ø)
primitives 87.82% <ø> (ø)

@onbjerg onbjerg added C-enhancement New feature or request A-tx-pool Related to the transaction mempool labels Aug 11, 2023
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, needs formatting

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse enabled auto-merge August 11, 2023 13:07
@mattsse mattsse added this pull request to the merge queue Aug 11, 2023
Merged via the queue into paradigmxyz:main with commit 427a839 Aug 11, 2023
23 checks passed
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make TransactionPool trait object safe
3 participants