Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove discarded transactions #4164

Merged
merged 1 commit into from
Aug 11, 2023
Merged

fix: remove discarded transactions #4164

merged 1 commit into from
Aug 11, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 11, 2023

poolupdates for discarded transactions were recorded properly but not actually applied

@mattsse mattsse requested a review from rkrasiuk August 11, 2023 14:02
@mattsse mattsse added C-bug An unexpected or incorrect behavior M-changelog This change should be included in the changelog A-tx-pool Related to the transaction mempool labels Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023 •
edited
Loading

Codecov Report

Merging #4164 (7800ffc) into main (427a839) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/pool/txpool.rs 72.95% <100.00%> (+13.56%) ⬆️

... and 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.85% <0.00%> (-0.02%) ⬇️
unit-tests 64.27% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.94% <ø> (ø)
blockchain tree 82.83% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.75% <ø> (ø)
trie 94.71% <ø> (ø)
txpool 52.00% <100.00%> (+4.41%) ⬆️
networking 77.72% <ø> (-0.02%) ⬇️
rpc 58.69% <ø> (+0.02%) ⬆️
consensus 63.73% <ø> (ø)
revm 32.18% <ø> (ø)
payload builder 6.57% <ø> (ø)
primitives 87.83% <ø> (ø)

rkrasiuk
rkrasiuk approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg!

@rkrasiuk rkrasiuk added this pull request to the merge queue Aug 11, 2023
Merged via the queue into main with commit 1c23075 Aug 11, 2023
24 checks passed
@rkrasiuk rkrasiuk deleted the matt/fix-discard branch August 11, 2023 14:38
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
@mattsse @alessandromazza98
fix: remove discarded transactions (paradigmxyz#4164)
7a85d03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool C-bug An unexpected or incorrect behavior M-changelog This change should be included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @rkrasiuk