Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return engine on fatal error #4184

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 14, 2023

this will now terminate the node if we encounter a fatal unrecoverable error, (database commit).

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #4184 (4e2c2c7) into main (4ff8bca) will decrease coverage by 0.06%.
Report is 2 commits behind head on main.
The diff coverage is 22.22%.

Impacted file tree graph

Files Changed Coverage Δ
crates/interfaces/src/executor.rs 100.00% <ø> (ø)
crates/consensus/beacon/src/engine/mod.rs 75.22% <22.22%> (-0.57%) ⬇️

... and 11 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.92% <0.00%> (-0.01%) ⬇️
unit-tests 64.22% <22.22%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.93% <ø> (ø)
blockchain tree 82.83% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.75% <ø> (ø)
trie 94.71% <ø> (ø)
txpool 51.43% <ø> (-0.60%) ⬇️
networking 77.71% <ø> (-0.04%) ⬇️
rpc 58.65% <ø> (-0.03%) ⬇️
consensus 63.53% <22.22%> (-0.20%) ⬇️
revm 32.19% <ø> (ø)
payload builder 6.57% <ø> (ø)
primitives 87.81% <ø> (-0.03%) ⬇️

@mattsse mattsse added this pull request to the merge queue Aug 14, 2023
Merged via the queue into main with commit 3c41e9f Aug 14, 2023
24 checks passed
@mattsse mattsse deleted the matt/return-engine-on-fatal-error branch August 14, 2023 17:36
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants