Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tree): log error on unreachable #4185

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Aug 14, 2023

Unreachable panic turned out to be not that unreachable on full node, so we better log the details of this error.

@shekhirin shekhirin requested a review from mattsse August 14, 2023 11:15
@shekhirin shekhirin marked this pull request as ready for review August 14, 2023 11:15
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #4185 (a5c1a03) into main (7223649) will decrease coverage by 0.06%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/blockchain-tree/src/blockchain_tree.rs 82.74% <0.00%> (-0.64%) ⬇️

... and 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.89% <0.00%> (-0.03%) ⬇️
unit-tests 64.20% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.60% <ø> (-0.34%) ⬇️
blockchain tree 82.56% <0.00%> (-0.27%) ⬇️
pipeline 90.07% <ø> (ø)
storage (db) 74.75% <ø> (ø)
trie 94.67% <ø> (-0.05%) ⬇️
txpool 52.00% <ø> (+0.57%) ⬆️
networking 77.72% <ø> (-0.06%) ⬇️
rpc 58.66% <ø> (-0.03%) ⬇️
consensus 63.73% <ø> (ø)
revm 32.19% <ø> (ø)
payload builder 6.57% <ø> (ø)
primitives 87.82% <ø> (-0.02%) ⬇️

@shekhirin shekhirin added this pull request to the merge queue Aug 14, 2023
Merged via the queue into main with commit 2aefbd3 Aug 14, 2023
24 checks passed
@shekhirin shekhirin deleted the alexey/tree-unreachable-log branch August 14, 2023 11:32
@shekhirin shekhirin added A-observability Related to tracing, metrics, logs and other observability tools A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Aug 14, 2023
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants