feat(interfaces): database write error details #4190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we encounter a database write error, all we get is
2023-08-13T10:10:38.571008Z ERROR consensus::engine: Encountered fatal error err=CanonicalCommit { inner: "Database write error code: -30418" }
which is not enough to debug what's happening as multiple writes can be made inside one function.
This solution is one way to help us debug write errors, other way is to provide more context on the caller side which is more cumbersome imo.