Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make build function configurable #4193

Merged
merged 1 commit into from
Aug 14, 2023
Merged

feat: make build function configurable #4193

merged 1 commit into from
Aug 14, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 14, 2023

#4153 followup that makes the build function configurable

@mattsse mattsse requested a review from Rjected as a code owner August 14, 2023 13:38
@mattsse mattsse added C-enhancement New feature or request M-changelog This change should be included in the changelog A-block-building Related to block building labels Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023 •
edited
Loading

Codecov Report

Merging #4193 (a6245f5) into main (b2be35c) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/payload/basic/src/lib.rs 0.00% <0.00%> (ø)

... and 14 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.88% <0.00%> (-0.01%) ⬇️
unit-tests 64.21% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.60% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.84% <ø> (ø)
trie 94.67% <ø> (-0.05%) ⬇️
txpool 51.43% <ø> (ø)
networking 77.70% <ø> (-0.21%) ⬇️
rpc 58.65% <ø> (-0.01%) ⬇️
consensus 63.73% <ø> (ø)
revm 32.19% <ø> (ø)
payload builder 6.82% <0.00%> (ø)
primitives 87.80% <ø> (-0.06%) ⬇️

@mattsse mattsse added this pull request to the merge queue Aug 14, 2023
Merged via the queue into main with commit 97404cf Aug 14, 2023
24 checks passed
@mattsse mattsse deleted the matt/make-builder-fn-configurable branch August 14, 2023 15:01
@clabby clabby mentioned this pull request Aug 14, 2023
Merged
10 tasks
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
@mattsse @alessandromazza98
feat: make build function configurable (paradigmxyz#4193)
fac959e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-block-building Related to block building C-enhancement New feature or request M-changelog This change should be included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @onbjerg