Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(doc): enhance append_blocks_with_post_state doc #4195

Merged
merged 1 commit into from
Aug 17, 2023
Merged

feat(doc): enhance append_blocks_with_post_state doc #4195

merged 1 commit into from
Aug 17, 2023

Conversation

tcoratger
Copy link
Contributor

Should solve #3577.

@codecov
Copy link

codecov bot commented Aug 14, 2023 •
edited
Loading

Codecov Report

Merging #4195 (4f4cbb2) into main (97404cf) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/storage/provider/src/traits/block.rs 34.54% <ø> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.88% <ø> (+<0.01%) ⬆️
unit-tests 64.25% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.60% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.84% <ø> (ø)
trie 94.71% <ø> (ø)
txpool 52.00% <ø> (-0.03%) ⬇️
networking 77.70% <ø> (-0.04%) ⬇️
rpc 58.64% <ø> (-0.02%) ⬇️
consensus 63.73% <ø> (ø)
revm 32.19% <ø> (ø)
payload builder 6.82% <ø> (ø)
primitives 87.83% <ø> (-0.01%) ⬇️

@mattsse mattsse added the C-docs An addition or correction to our documentation label Aug 14, 2023
mattsse
mattsse approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Aug 17, 2023
Merged via the queue into paradigmxyz:main with commit e948928 Aug 17, 2023
23 checks passed
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
@tcoratger @alessandromazza98
feat(doc): enhance append_blocks_with_post_state doc (paradigmxyz#4195
20e15da 
)
@tcoratger tcoratger mentioned this pull request Aug 25, 2023
Closed
@tcoratger tcoratger deleted the append-blocks-doc branch September 21, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
C-docs An addition or correction to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcoratger @mattsse