Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move bitflags to workspace #4220

Merged
merged 2 commits into from
Aug 16, 2023
Merged

chore: move bitflags to workspace #4220

merged 2 commits into from
Aug 16, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 16, 2023

🤖 Generated by Copilot at 46772ff

This pull request refactors the bitflags dependency across the workspace to use a single version defined in the root Cargo.toml file. This avoids duplication and conflicts and improves compatibility and consistency.

@mattsse mattsse added the A-dependencies Pull requests or issues that are about dependencies label Aug 16, 2023
@mattsse mattsse enabled auto-merge August 16, 2023 12:12
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #4220 (74f1a42) into main (7cd7859) will decrease coverage by 0.03%.
The diff coverage is 25.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/pool/state.rs 63.54% <25.00%> (-27.51%) ⬇️

... and 3 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.83% <25.00%> (-0.03%) ⬇️
unit-tests 64.11% <25.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.14% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.79% <ø> (ø)
trie 94.71% <ø> (ø)
txpool 51.07% <25.00%> (-0.37%) ⬇️
networking 77.74% <ø> (ø)
rpc 58.66% <ø> (ø)
consensus 63.53% <ø> (ø)
revm 32.15% <ø> (ø)
payload builder 6.82% <ø> (ø)
primitives 87.87% <ø> (+0.01%) ⬆️

@mattsse mattsse added this pull request to the merge queue Aug 16, 2023
Merged via the queue into main with commit 43601e3 Aug 16, 2023
25 checks passed
@mattsse mattsse deleted the matt/bump-bitflags branch August 16, 2023 12:27
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants