debug_backtraceAt #4232
Merged
debug_backtraceAt #4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
... and 40 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
requested changes
Aug 16, 2023
crates/rpc/rpc-api/src/debug.rs
Outdated
| @@ -123,4 +123,10 @@ pub trait DebugApi { | |||
| opts: Option<GethDebugTracingOptions>, | |||
| state_override: Option<StateOverride>, | |||
| ) -> RpcResult<Vec<GethTrace>>; | |||
|
|
|||
| ///Sets the logging backtrace location. When a backtrace location is set and a log message is | |||
There was a problem hiding this comment.
Suggested change
| ///Sets the logging backtrace location. When a backtrace location is set and a log message is | |
| /// Sets the logging backtrace location. When a backtrace location is set and a log message is |
crates/rpc/rpc/src/debug.rs
Outdated
Comment on lines
48
to
53
| use lazy_static::lazy_static; | ||
| use std::sync::Mutex; | ||
| lazy_static! { | ||
| static ref LOCATION: Mutex<String> = Mutex::new(String::new()); | ||
| static ref BACKTRACE_ENABLED: Mutex<bool> = Mutex::new(false); | ||
| } |
There was a problem hiding this comment.
I don't want to support this atm
so this function should just return unimplemented
crates/rpc/rpc/src/debug.rs
Outdated
Comment on lines
653
to
657
| let mut parts: Vec<&str> = location.split(':').collect(); | ||
| if parts.len() != 2 { | ||
| return Err(internal_rpc_err("Invalid location format".to_string())) | ||
| } | ||
| parts[0] = parts[0].trim(); |
|
So I will leave the rest of the functions unimplemented for now. We can then implement them one by one as you plan it |
mattsse
approved these changes
Aug 18, 2023
gakonst
reviewed
Aug 18, 2023
| @@ -25,6 +25,7 @@ reth-tasks.workspace = true | |||
| reth-metrics.workspace = true | |||
| reth-consensus-common = { path = "../../consensus/common" } | |||
| reth-rpc-types-compat.workspace = true | |||
| lazy_static = "*" | |||
PlamenHristov
pushed a commit
to PlamenHristov/reth
that referenced
this pull request
Aug 19, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
alessandromazza98
pushed a commit
to alessandromazza98/reth
that referenced
this pull request
Aug 19, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1701
https://geth.ethereum.org/docs/interacting-with-geth/rpc/ns-debug
https://github.com/ethereum/go-ethereum/blob/386cba15b5ee56908e3b33f7ee52a4c8486d5d8f/log/handler_glog.go#L151
https://github.com/ethereum/go-ethereum/blob/386cba15b5ee56908e3b33f7ee52a4c8486d5d8f/internal/debug/api.go#L70