Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom PoolTransaction errors #4237

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 16, 2023

add a new trait that makes it possible to configure additional errors during validation

fyi @refcell

ref anton-rs#65

@mattsse mattsse added C-enhancement New feature or request A-tx-pool Related to the transaction mempool labels Aug 16, 2023
@mattsse mattsse requested a review from Rjected as a code owner August 16, 2023 18:13
@refcell
Copy link
Contributor

refcell commented Aug 16, 2023

Once this is merged, we will update clabby/op-reth on reth upstream trunk and subsequently rebase anton-rs#65 on clabby/op-reth with these changes :)

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #4237 (243b9d6) into main (8a2c3ab) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc/src/eth/error.rs 9.94% <0.00%> (-0.06%) ⬇️
crates/transaction-pool/src/error.rs 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.80% <0.00%> (-0.03%) ⬇️
unit-tests 64.10% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.13% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.73% <ø> (ø)
trie 94.71% <ø> (+0.04%) ⬆️
txpool 51.05% <0.00%> (-0.02%) ⬇️
networking 77.53% <ø> (-0.11%) ⬇️
rpc 58.64% <0.00%> (-0.02%) ⬇️
consensus 63.53% <ø> (ø)
revm 32.15% <ø> (ø)
payload builder 6.82% <ø> (ø)
primitives 87.91% <ø> (-0.01%) ⬇️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rjected
Copy link
Member

Rjected commented Aug 16, 2023

looks like it needs a doc link fix

@mattsse mattsse enabled auto-merge August 16, 2023 18:53
@mattsse mattsse added this pull request to the merge queue Aug 16, 2023
Merged via the queue into main with commit 45db5a6 Aug 16, 2023
24 checks passed
@mattsse mattsse deleted the matt/add-other-txs-error branch August 16, 2023 19:12
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants