Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename transaction #4252

Merged
merged 2 commits into from
Aug 17, 2023
Merged

chore: rename transaction #4252

merged 2 commits into from
Aug 17, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 17, 2023

rename the transaction to make it clear that this is explicitly for eth.

@mattsse mattsse requested a review from gakonst as a code owner August 17, 2023 18:18
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Aug 17, 2023
@mattsse mattsse requested a review from Rjected August 17, 2023 18:29
@mattsse mattsse added the M-changelog This change should be included in the changelog label Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #4252 (a29b6b1) into main (60ad6b2) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/lib.rs 42.07% <0.00%> (ø)
crates/transaction-pool/src/noop.rs 12.85% <0.00%> (ø)
crates/transaction-pool/src/traits.rs 9.09% <0.00%> (ø)

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.87% <0.00%> (-0.01%) ⬇️
unit-tests 63.75% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.13% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.71% <ø> (ø)
trie 94.71% <ø> (ø)
txpool 49.03% <0.00%> (-0.57%) ⬇️
networking 77.47% <ø> (-0.06%) ⬇️
rpc 58.64% <ø> (-0.02%) ⬇️
consensus 63.53% <ø> (ø)
revm 32.15% <ø> (ø)
payload builder 6.82% <ø> (ø)
primitives 86.31% <ø> (ø)

@mattsse mattsse added this pull request to the merge queue Aug 17, 2023
Merged via the queue into main with commit 0bcd388 Aug 17, 2023
24 checks passed
@mattsse mattsse deleted the matt/rename-transaction branch August 17, 2023 18:53
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain M-changelog This change should be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants