Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: use U64 for transaction_index #4261

Merged
merged 5 commits into from
Aug 18, 2023
Merged

dev: use U64 for transaction_index #4261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
723b88b
dev: skip serialization for tx receipt index and to if none
ftupas Aug 18, 2023
4e0aa47
dev: use u64 instead and remove skip
ftupas Aug 18, 2023
011dd8d
feat: use U64
ftupas Aug 18, 2023
bc76e9d
Update crates/rpc/rpc/src/eth/api/transactions.rs
mattsse Aug 18, 2023
5f8f500
Update crates/rpc/rpc/src/eth/api/transactions.rs
mattsse Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/rpc/rpc-types/src/eth/transaction/receipt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ pub struct TransactionReceipt {
/// Transaction Hash.
pub transaction_hash: Option<H256>,
/// Index within the block.
pub transaction_index: Option<U256>,
pub transaction_index: U64,
/// Hash of the block this transaction was included within.
pub block_hash: Option<H256>,
/// Number of the block this transaction was included within.
Expand Down
2 changes: 1 addition & 1 deletion crates/rpc/rpc/src/eth/api/transactions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,7 +859,7 @@ pub(crate) fn build_transaction_receipt_with_block_receipts(

let mut res_receipt = TransactionReceipt {
transaction_hash: Some(meta.tx_hash),
transaction_index: Some(U256::from(meta.index)),
transaction_index: meta.index.into(),
block_hash: Some(meta.block_hash),
block_number: Some(U256::from(meta.block_number)),
from: transaction.signer(),
Expand Down
Loading