-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump metrics
#4265
Merged
Merged
chore: bump metrics
#4265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
requested review from
mattsse,
onbjerg,
rakita,
rkrasiuk,
Rjected,
joshieDo and
gakonst
as code owners
August 18, 2023 12:30
Codecov Report
... and 4 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
approved these changes
Aug 18, 2023
shekhirin
force-pushed
the
alexey/process-metrics-prefix
branch
2 times, most recently
from
August 18, 2023 14:44
b03ad73
to
7a32e44
Compare
shekhirin
added
C-bug
An unexpected or incorrect behavior
A-observability
Related to tracing, metrics, logs and other observability tools
labels
Aug 18, 2023
PlamenHristov
pushed a commit
to PlamenHristov/reth
that referenced
this pull request
Aug 19, 2023
alessandromazza98
pushed a commit
to alessandromazza98/reth
that referenced
this pull request
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-observability
Related to tracing, metrics, logs and other observability tools
C-bug
An unexpected or incorrect behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
metrics-process
metrics doesn't have areth_
prefix.Root cause
metrics-process
dependency was updated to latest version in #3988, and with it themetrics
dependency made a bumpreth/Cargo.lock
Line 3966 in efab153
while other crates depending on
metrics
continued to use older versionreth/Cargo.lock
Line 5692 in efab153
The problem with this is that
metrics-macro
uses the globalRECORDER
variable which we configure using older version ofmetrics
cratereth/bin/reth/src/prometheus_exporter.rs
Lines 34 to 38 in efab153
metrics-process
uses) doesn't see it.Solution
Use the same version of
metrics
dependency everywhere, so bump it to latest0.21.1
. The tricky part is this change metrics-rs/metrics#358, which required defining themetrics
dependency on the crate level (https://doc.rust-lang.org/reference/paths.html#path-qualifiers).