Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent node info zero address #4268

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix: prevent node info zero address #4268

merged 1 commit into from
Aug 18, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 18, 2023

closes #4222

zero address is invalid here

@mattsse mattsse requested a review from Rjected as a code owner August 18, 2023 14:48
@mattsse mattsse requested a review from rkrasiuk August 18, 2023 14:48
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-networking Related to networking in general labels Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023 •
edited
Loading

Codecov Report

Merging #4268 (4a4223e) into main (efab153) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/net/network/src/network.rs 55.95% <0.00%> (-2.80%) ⬇️

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.88% <0.00%> (-0.03%) ⬇️
unit-tests 63.76% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.13% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.71% <ø> (ø)
trie 94.71% <ø> (ø)
txpool 49.59% <ø> (+0.53%) ⬆️
networking 77.43% <0.00%> (-0.10%) ⬇️
rpc 58.63% <ø> (ø)
consensus 63.53% <ø> (ø)
revm 32.15% <ø> (ø)
payload builder 6.82% <ø> (ø)
primitives 86.30% <ø> (-0.02%) ⬇️

rkrasiuk
rkrasiuk approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mattsse mattsse added this pull request to the merge queue Aug 18, 2023
Merged via the queue into main with commit 849a47e Aug 18, 2023
24 checks passed
@mattsse mattsse deleted the matt/map-local-addr branch August 18, 2023 15:18
PlamenHristov pushed a commit to PlamenHristov/reth that referenced this pull request Aug 19, 2023
@mattsse @PlamenHristov
fix: prevent node info zero address (paradigmxyz#4268)
ac3ab82
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
@mattsse @alessandromazza98
fix: prevent node info zero address (paradigmxyz#4268)
1ba0de4
@Rjected Rjected mentioned this pull request May 6, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support external address in discv4 handle type
2 participants
@mattsse @rkrasiuk