Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support blob transactions in manager #4294

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 21, 2023

this enables blob transactions in network <-> pool interface

ensures no eip4844 are broadcasted

transactions are not enabled by the pool and will be rejected

@mattsse mattsse added M-changelog This change should be included in the changelog A-networking Related to networking in general M-eip This change relates to the implementation of an EIP labels Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #4294 (7ae0775) into main (eaca2a4) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 84.21%.

Impacted file tree graph

Files Changed Coverage Δ
crates/primitives/src/transaction/pooled.rs 53.08% <69.23%> (+18.73%) ⬆️
crates/net/network/src/transactions.rs 60.83% <90.90%> (+0.94%) ⬆️
crates/net/eth-wire/src/types/broadcast.rs 73.66% <100.00%> (+0.28%) ⬆️

... and 13 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.83% <0.00%> (-0.03%) ⬇️
unit-tests 63.74% <84.21%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.12% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.77% <ø> (ø)
trie 94.85% <ø> (ø)
txpool 48.22% <ø> (-0.47%) ⬇️
networking 77.46% <92.00%> (-0.11%) ⬇️
rpc 58.70% <ø> (-0.01%) ⬇️
consensus 63.53% <ø> (ø)
revm 32.02% <ø> (-0.02%) ⬇️
payload builder 6.82% <ø> (ø)
primitives 86.14% <69.23%> (+0.28%) ⬆️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, try_from_broadcast makes this change pretty straightforward

@mattsse mattsse added this pull request to the merge queue Aug 21, 2023
Merged via the queue into main with commit 3b404ac Aug 21, 2023
24 checks passed
@mattsse mattsse deleted the matt/supported-pooled-transactions branch August 21, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Related to networking in general M-changelog This change should be included in the changelog M-eip This change relates to the implementation of an EIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants