Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Validator::on_new_head_block #4303

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 21, 2023

closes #4244

this allows updating values that depend on the current height, like enabling fork based on timestamp or fees like in op-reth

cc @refcell

@mattsse mattsse added C-enhancement New feature or request A-tx-pool Related to the transaction mempool labels Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #4303 (2f6c8e1) into main (34b68de) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/lib.rs 37.91% <0.00%> (ø)
crates/transaction-pool/src/maintain.rs 3.17% <0.00%> (+0.06%) ⬆️
crates/transaction-pool/src/pool/mod.rs 44.91% <0.00%> (+0.78%) ⬆️
crates/transaction-pool/src/traits.rs 7.38% <0.00%> (-0.64%) ⬇️
crates/transaction-pool/src/validate/mod.rs 55.10% <0.00%> (-0.57%) ⬇️

... and 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.83% <0.00%> (+<0.01%) ⬆️
unit-tests 63.76% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.12% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.77% <ø> (ø)
trie 94.85% <ø> (+0.03%) ⬆️
txpool 48.20% <0.00%> (-0.03%) ⬇️
networking 77.53% <ø> (-0.02%) ⬇️
rpc 58.81% <ø> (-0.01%) ⬇️
consensus 63.53% <ø> (ø)
revm 32.01% <ø> (ø)
payload builder 6.82% <ø> (ø)
primitives 86.16% <ø> (+0.01%) ⬆️

@mattsse mattsse requested a review from Rjected August 21, 2023 22:40
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to have a block ref here

@mattsse mattsse added this pull request to the merge queue Aug 21, 2023
Merged via the queue into main with commit 07a1af8 Aug 21, 2023
24 checks passed
@mattsse mattsse deleted the matt/add-new-validator-fn branch August 21, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend TransactionValidator trait to set block specific values
2 participants