Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(trie): proofs should be generic over hashed cursor factory #4310

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

rkrasiuk
Copy link
Member

Description

Akin to StateRoot & StorageRoot, the proof generator & restorer should be generic over hashed cursor factory.

@rkrasiuk rkrasiuk added C-debt Refactor of code section that is hard to understand or maintain A-trie Related to Merkle Patricia Trie implementation labels Aug 22, 2023
@rkrasiuk rkrasiuk requested a review from mattsse August 22, 2023 09:58
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #4310 (8857bf8) into main (07a1af8) will increase coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/trie/src/proof.rs 97.24% <100.00%> (+0.23%) ⬆️

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.83% <0.00%> (-0.01%) ⬇️
unit-tests 63.79% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.12% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.77% <ø> (ø)
trie 94.84% <100.00%> (-0.01%) ⬇️
txpool 48.71% <ø> (+0.51%) ⬆️
networking 77.47% <ø> (-0.02%) ⬇️
rpc 58.80% <ø> (-0.09%) ⬇️
consensus 63.53% <ø> (ø)
revm 32.01% <ø> (ø)
payload builder 6.82% <ø> (ø)
primitives 86.14% <ø> (-0.03%) ⬇️

@rkrasiuk rkrasiuk requested a review from Rjected August 22, 2023 14:01
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rkrasiuk rkrasiuk added this pull request to the merge queue Aug 23, 2023
Merged via the queue into main with commit 77621fa Aug 23, 2023
24 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/proofs-generic-over-hashed-cursor-factory branch August 23, 2023 07:16
@gakonst
Copy link
Member

gakonst commented Aug 23, 2023

Nice - OK this sets us up to do the Storage Proof per account, vs just Account Proofs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-trie Related to Merkle Patricia Trie implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants