Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use get_pooled_transaction_elements in network manager #4329

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 23, 2023

use new TransactionPool::get_pooled_transaction_elements for in the manager, enforces softlimit

closes #4201

@mattsse mattsse requested a review from Rjected as a code owner August 23, 2023 15:06
@mattsse mattsse added A-tx-pool Related to the transaction mempool A-networking Related to networking in general labels Aug 23, 2023
@mattsse mattsse force-pushed the matt/use-getpooled-elements-in-manager branch from 6f600a3 to 76c0d71 Compare August 23, 2023 15:09
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #4329 (76c0d71) into main (5a7a57d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/lib.rs 38.62% <ø> (+2.11%) ⬆️
crates/net/network/src/transactions.rs 60.62% <100.00%> (-0.22%) ⬇️

... and 14 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.81% <0.00%> (-0.01%) ⬇️
unit-tests 63.72% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.11% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.77% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 47.94% <ø> (+0.65%) ⬆️
networking 77.50% <100.00%> (+<0.01%) ⬆️
rpc 58.79% <ø> (-0.03%) ⬇️
consensus 63.53% <ø> (ø)
revm 32.01% <ø> (ø)
payload builder 6.78% <ø> (ø)
primitives 86.08% <ø> (-0.01%) ⬇️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattsse mattsse added this pull request to the merge queue Aug 23, 2023
Merged via the queue into main with commit 1343644 Aug 23, 2023
24 checks passed
@mattsse mattsse deleted the matt/use-getpooled-elements-in-manager branch August 23, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Related to networking in general A-tx-pool Related to the transaction mempool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adhere to solftresponse limit for getPooled transactions
3 participants