Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CancunPayloadFields for engine_newPayloadV3 #4407

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Aug 30, 2023

This introduces a struct for the extra fields introduced in engine_newPayloadV3, because these fields are provided together when engine_newPayloadV3 is called. Either they both exist, or are both None.

@Rjected Rjected added C-enhancement New feature or request A-rpc Related to the RPC implementation A-consensus Related to the consensus engine labels Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #4407 (c9fa0c0) into main (e576c00) will increase coverage by 0.00%.
The diff coverage is 56.25%.

Impacted file tree graph

Files Changed Coverage Δ
crates/consensus/beacon/src/engine/message.rs 38.46% <ø> (ø)
crates/rpc/rpc-engine-api/src/engine_api.rs 80.46% <0.00%> (-0.47%) ⬇️
crates/rpc/rpc-types/src/eth/engine/cancun.rs 0.00% <0.00%> (ø)
crates/consensus/beacon/src/engine/mod.rs 75.16% <75.00%> (-0.26%) ⬇️
crates/consensus/beacon/src/engine/handle.rs 88.88% <100.00%> (-0.91%) ⬇️
crates/consensus/beacon/src/engine/test_utils.rs 77.49% <100.00%> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.69% <12.50%> (-0.03%) ⬇️
unit-tests 63.78% <56.25%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 29.21% <ø> (ø)
blockchain tree 83.52% <ø> (ø)
pipeline 90.25% <ø> (ø)
storage (db) 74.81% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 48.79% <ø> (+0.49%) ⬆️
networking 77.46% <ø> (-0.07%) ⬇️
rpc 57.30% <0.00%> (-0.03%) ⬇️
consensus 63.52% <90.00%> (-0.14%) ⬇️
revm 31.74% <ø> (ø)
payload builder 6.37% <ø> (ø)
primitives 86.21% <ø> (ø)

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

it's a bit weird that this a new argument and not additional fields, but we should just mirror that

@Rjected Rjected force-pushed the dan/cancun-field-object-beacon-message branch from 35a2ba1 to c9fa0c0 Compare August 30, 2023 16:18
@Rjected Rjected enabled auto-merge August 30, 2023 16:23
@Rjected Rjected added this pull request to the merge queue Aug 30, 2023
Merged via the queue into main with commit 1c83740 Aug 30, 2023
24 checks passed
@Rjected Rjected deleted the dan/cancun-field-object-beacon-message branch August 30, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Related to the consensus engine A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants