Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add eip4844 fields to rpc transaction #4422

Merged
merged 1 commit into from
Aug 31, 2023
Merged

feat: add eip4844 fields to rpc transaction #4422

merged 1 commit into from
Aug 31, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 31, 2023

add blobVersionedHashes and maxFeePerBlobGas to rpc transaction

@mattsse mattsse requested a review from Rjected as a code owner August 31, 2023 00:18
@mattsse mattsse added the A-rpc Related to the RPC implementation label Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Merging #4422 (c17c878) into main (b5aa943) will increase coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 16.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc-types-compat/src/transaction/mod.rs 0.00% <0.00%> (ø)
crates/rpc/rpc-types/src/eth/transaction/mod.rs 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.73% <0.00%> (+0.03%) ⬆️
unit-tests 63.75% <16.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 29.21% <ø> (ø)
blockchain tree 83.52% <ø> (ø)
pipeline 90.25% <ø> (ø)
storage (db) 74.81% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 48.60% <ø> (+0.48%) ⬆️
networking 77.52% <ø> (-0.16%) ⬇️
rpc 57.55% <16.00%> (+0.26%) ⬆️
consensus 63.42% <ø> (-0.18%) ⬇️
revm 31.74% <ø> (ø)
payload builder 6.37% <ø> (ø)
primitives 86.16% <ø> (-0.03%) ⬇️

Rjected
Rjected approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse enabled auto-merge August 31, 2023 00:30
@mattsse mattsse added this pull request to the merge queue Aug 31, 2023
Merged via the queue into main with commit 3d9e968 Aug 31, 2023
24 checks passed
@mattsse mattsse deleted the matt/add-rpc-tx-fields branch August 31, 2023 00:40
shekhirin pushed a commit that referenced this pull request Aug 31, 2023
@mattsse @shekhirin
feat: add eip4844 fields to rpc transaction (#4422)
89529da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected