Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): run check and clippy on tests and benches too #4587

Merged
merged 10 commits into from
Sep 14, 2023
Merged

chore(ci): run check and clippy on tests and benches too #4587

merged 10 commits into from
Sep 14, 2023

Conversation

shekhirin
Copy link
Collaborator

No description provided.

@shekhirin shekhirin changed the title chore(ci): cargo check on tests and benches chore(ci): run check/fmt/clippy on tests and benches too Sep 13, 2023
@shekhirin shekhirin changed the title chore(ci): run check/fmt/clippy on tests and benches too chore(ci): run check and clippy on tests and benches too Sep 13, 2023
@shekhirin shekhirin marked this pull request as ready for review September 13, 2023 18:31
mattsse
mattsse approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable

@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Merging #4587 (a1c8750) into main (723036b) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/trie/src/trie.rs 96.68% <ø> (ø)
crates/prune/src/pruner.rs 82.87% <100.00%> (+0.03%) ⬆️
crates/rpc/rpc-engine-api/src/engine_api.rs 79.23% <100.00%> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.62% <0.00%> (-0.01%) ⬇️
unit-tests 64.03% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.85% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.53% <ø> (ø)
storage (db) 75.32% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 49.26% <ø> (-0.50%) ⬇️
networking 77.27% <ø> (+0.03%) ⬆️
rpc 57.35% <100.00%> (-0.01%) ⬇️
consensus 63.40% <ø> (ø)
revm 31.56% <ø> (ø)
payload builder 6.12% <ø> (ø)
primitives 86.53% <ø> (-0.01%) ⬇️

@shekhirin shekhirin added this pull request to the merge queue Sep 14, 2023
Merged via the queue into main with commit a8e0880 Sep 14, 2023
22 checks passed
@shekhirin shekhirin deleted the alexey/cargo-check branch September 14, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @mattsse