fix: apply FCU on invalid PayloadAttributes #4591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-bug
Codecov Report
... and 10 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
requested changes
Sep 13, 2023
Comment on lines
158
to
176
| let attr_validation_res = | ||
| self.validate_version_specific_fields(EngineApiMessageVersion::V2, &attrs.into()); | ||
|
|
||
| // From the engine API spec: | ||
| // | ||
| // Client software MUST ensure that payloadAttributes.timestamp is greater than | ||
| // timestamp of a block referenced by forkchoiceState.headBlockHash. If this condition | ||
| // isn't held client software MUST respond with -38003: Invalid payload attributes and | ||
| // MUST NOT begin a payload build process. In such an event, the forkchoiceState | ||
| // update MUST NOT be rolled back. | ||
| // | ||
| // NOTE: This will also apply to the validation result for the shanghai-specific fields | ||
| // provided in the payload attributes. | ||
| // | ||
| // To do this, we set the payload attrs to `None` if attribute validation failed, but | ||
| // we still apply the forkchoice update. | ||
| if let Err(err) = attr_validation_res { | ||
| let fcu_res = self.inner.beacon_consensus.fork_choice_updated(state, None).await?; | ||
| // TODO: decide if we want this branch - the FCU INVALID response might be more |
There was a problem hiding this comment.
this is duplicated code, right?
I think this could be moved to a helper function instead
Rjected
force-pushed
the
dan/apply-fcu-on-invalid-payload-attrs
branch
from
ca6d843
to
4acbc3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4589
Makes the
Invalid PayloadAttributes: Missing BeaconRoothive test passThis will call
fork_choice_updatedwithNoneif the payload attributes fail validation.