Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(txpool): pending subpool basefee update #4610

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

rkrasiuk
Copy link
Member

Closes #4609.

Description

Clear ordered lists first before the transactions are re-inserted with new priority.

@rkrasiuk rkrasiuk added C-bug An unexpected or incorrect behavior A-tx-pool Related to the transaction mempool labels Sep 15, 2023
@rkrasiuk rkrasiuk marked this pull request as draft September 15, 2023 12:00
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/fix-pending-subpool-basefee-update branch 2 times, most recently from 9370a0e to 3070019 Compare September 15, 2023 12:08
@rkrasiuk rkrasiuk marked this pull request as ready for review September 15, 2023 12:14
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #4610 (2c95a48) into main (a8e0880) will decrease coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is 96.55%.

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/pool/pending.rs 83.11% <96.15%> (-0.15%) ⬇️
crates/transaction-pool/src/pool/size.rs 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.63% <0.00%> (-0.01%) ⬇️
unit-tests 64.02% <96.55%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.85% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.53% <ø> (ø)
storage (db) 75.32% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 49.27% <96.55%> (-0.49%) ⬇️
networking 77.21% <ø> (-0.03%) ⬇️
rpc 57.35% <ø> (-0.01%) ⬇️
consensus 63.40% <ø> (ø)
revm 31.56% <ø> (ø)
payload builder 6.12% <ø> (ø)
primitives 86.51% <ø> (-0.01%) ⬇️

@rkrasiuk rkrasiuk force-pushed the rkrasiuk/fix-pending-subpool-basefee-update branch from 3070019 to 2c95a48 Compare September 15, 2023 12:38
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

I'll add a few tests for this

@mattsse mattsse added this pull request to the merge queue Sep 15, 2023
Merged via the queue into main with commit 6b8db8a Sep 15, 2023
22 checks passed
@mattsse mattsse deleted the rkrasiuk/fix-pending-subpool-basefee-update branch September 15, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pending pool basefee updates are unsound
2 participants