Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tx pool mock public #4611

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Make tx pool mock public #4611

merged 1 commit into from
Sep 15, 2023

Conversation

MetaB0y
Copy link
Contributor

@MetaB0y MetaB0y commented Sep 15, 2023

I am sure it can be useful for testing reth extensions (because it is useful for me).

Also, I don't see a serious reason for not making those mocks (and usually any mocks in general) public.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable

@mattsse mattsse added the A-tx-pool Related to the transaction mempool label Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #4611 (fdcf966) into main (b156cb9) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/test_utils/mock.rs 56.15% <0.00%> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.72% <0.00%> (+<0.01%) ⬆️
unit-tests 63.97% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.85% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.53% <ø> (ø)
storage (db) 75.32% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 49.14% <0.00%> (ø)
networking 77.20% <ø> (-0.07%) ⬇️
rpc 57.36% <ø> (-0.01%) ⬇️
consensus 63.40% <ø> (ø)
revm 31.56% <ø> (ø)
payload builder 6.12% <ø> (ø)
primitives 86.51% <ø> (-0.03%) ⬇️

@mattsse mattsse added this pull request to the merge queue Sep 15, 2023
Merged via the queue into paradigmxyz:main with commit a572c3b Sep 15, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants