Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enough blob fee tx state #4680

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 20, 2023

add a new tx state bit field that represents whether the tx satisfies the dynamic blob fee.

this does not affect normal transactions.

this needs additional changes to how subpools are handled in followups

@mattsse mattsse added the A-tx-pool Related to the transaction mempool label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #4680 (cb2db71) into main (afbe88f) will decrease coverage by 0.01%.
The diff coverage is 87.75%.

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/pool/state.rs 61.00% <25.00%> (-2.55%) ⬇️
crates/transaction-pool/src/pool/txpool.rs 73.85% <100.00%> (+0.84%) ⬆️

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.74% <14.28%> (-0.01%) ⬇️
unit-tests 63.37% <87.75%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.17% <ø> (ø)
blockchain tree 83.75% <ø> (ø)
pipeline 88.54% <ø> (ø)
storage (db) 73.01% <ø> (ø)
trie 94.73% <ø> (ø)
txpool 49.82% <87.75%> (+0.38%) ⬆️
networking 77.10% <ø> (-0.09%) ⬇️
rpc 57.81% <ø> (-0.01%) ⬇️
consensus 63.18% <ø> (ø)
revm 28.16% <ø> (ø)
payload builder 8.45% <ø> (ø)
primitives 86.55% <ø> (+0.02%) ⬆️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM

@mattsse mattsse added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit 1718f14 Sep 20, 2023
22 checks passed
@mattsse mattsse deleted the matt/add-blob-fee-tx-state-bit branch September 20, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants