Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update revm and map new errors to rpc #4696

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Sep 20, 2023

This updates revm, adding the new EIP-4844 related errors to RpcInvalidTransactionError

@Rjected Rjected added the A-rpc Related to the RPC implementation label Sep 20, 2023
@mattsse
Copy link
Collaborator

mattsse commented Sep 20, 2023

additional breaking changes @Rjected

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #4696 (f81b7c9) into main (6016da7) will decrease coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
...revm/revm-inspectors/src/tracing/builder/parity.rs 0.00% <0.00%> (ø)
...es/revm/revm-inspectors/src/tracing/js/bindings.rs 16.55% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/mod.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/types.rs 0.00% <0.00%> (ø)
crates/rpc/rpc/src/eth/error.rs 9.34% <0.00%> (-0.21%) ⬇️

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.72% <0.00%> (-0.03%) ⬇️
unit-tests 63.35% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.17% <ø> (ø)
blockchain tree 83.75% <ø> (ø)
pipeline 88.54% <ø> (ø)
storage (db) 73.01% <ø> (ø)
trie 94.73% <ø> (-0.04%) ⬇️
txpool 49.44% <ø> (-0.49%) ⬇️
networking 77.07% <ø> (-0.10%) ⬇️
rpc 57.79% <0.00%> (-0.03%) ⬇️
consensus 63.25% <ø> (ø)
revm 28.16% <0.00%> (ø)
payload builder 8.45% <ø> (ø)
primitives 86.54% <ø> (-0.02%) ⬇️

@Rjected Rjected added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit 0a17bc6 Sep 20, 2023
23 checks passed
@Rjected Rjected deleted the dan/add-new-revm-errors-to-rpc branch September 20, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants