Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add CANCUN to revm_spec_by_timestamp_after_merge #4699

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Sep 20, 2023

This was preventing the payload builder from properly setting the revm spec, now this properly sets the spec

@Rjected Rjected added C-bug An unexpected or incorrect behavior A-execution Related to the Execution and EVM A-block-building Related to block building labels Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #4699 (b5102ff) into main (a52b433) will increase coverage by 0.02%.
The diff coverage is 72.72%.

Impacted file tree graph

Files Changed Coverage Δ
crates/revm/revm-primitives/src/config.rs 91.19% <72.72%> (-0.09%) ⬇️

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.72% <0.00%> (-0.02%) ⬇️
unit-tests 63.33% <72.72%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.17% <ø> (ø)
blockchain tree 83.75% <ø> (ø)
pipeline 88.53% <ø> (ø)
storage (db) 72.51% <ø> (ø)
trie 94.73% <ø> (ø)
txpool 49.91% <ø> (+0.46%) ⬆️
networking 77.10% <ø> (-0.01%) ⬇️
rpc 57.81% <ø> (ø)
consensus 63.21% <ø> (ø)
revm 28.38% <72.72%> (+0.14%) ⬆️
payload builder 8.45% <ø> (ø)
primitives 86.55% <ø> (-0.01%) ⬇️

@mattsse mattsse added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit 30b4ddb Sep 20, 2023
22 checks passed
@mattsse mattsse deleted the dan/set-revm-spec-to-cancun-post-merge branch September 20, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-block-building Related to block building A-execution Related to the Execution and EVM C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants