Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interfaces): better doc for BlockValidationError and BlockExecutionError #4708

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

tcoratger
Copy link
Contributor

This PR contains a better code documentation for BlockValidationError and BlockExecutionError enums inside the interfaces crate.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #4708 (0219e1d) into main (5be8ae4) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/interfaces/src/executor.rs 40.00% <ø> (ø)

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.74% <ø> (-0.01%) ⬇️
unit-tests 63.33% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.17% <ø> (ø)
blockchain tree 83.75% <ø> (ø)
pipeline 88.53% <ø> (ø)
storage (db) 72.52% <ø> (ø)
trie 94.77% <ø> (+0.03%) ⬆️
txpool 50.28% <ø> (+0.46%) ⬆️
networking 77.12% <ø> (-0.03%) ⬇️
rpc 57.84% <ø> (ø)
consensus 62.97% <ø> (-0.13%) ⬇️
revm 28.38% <ø> (ø)
payload builder 8.35% <ø> (ø)
primitives 86.53% <ø> (-0.02%) ⬇️

@mattsse mattsse added this pull request to the merge queue Sep 21, 2023
Merged via the queue into paradigmxyz:main with commit 5779fa4 Sep 21, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants