-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CI): add timeout to CI #4728
Conversation
Codecov Report
see 12 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add these to tests workflows too?
@DaniPopes Yes sure, I've just extended, tell me if this is better or if you see other places with this should be set like that? For me this seems good like that, I've pushed the timeout to 60 minutes at the most critical places. |
It's missing integration.yml I think then we're good |
Done, thanks for the tip, I don't know why I was thinking that "solve" did the same job but I should have checked if the issues closed automatically... |
Should resolve #4727.