Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CI): add timeout to CI #4728

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Conversation

tcoratger
Copy link
Contributor

@tcoratger tcoratger commented Sep 22, 2023

Should resolve #4727.

@mattsse mattsse added C-test A change that impacts how or what we test A-meta Changes in the contributor workflow and planning labels Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #4728 (0bd9cb7) into main (e83d3aa) will decrease coverage by 0.02%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

see 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.55% <ø> (+<0.01%) ⬆️
unit-tests 63.56% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.17% <ø> (ø)
blockchain tree 83.73% <ø> (ø)
pipeline 88.53% <ø> (ø)
storage (db) 73.70% <ø> (ø)
trie 94.73% <ø> (-0.04%) ⬇️
txpool 49.82% <ø> (ø)
networking 77.14% <ø> (-0.06%) ⬇️
rpc 57.86% <ø> (-0.01%) ⬇️
consensus 63.09% <ø> (ø)
revm 28.33% <ø> (ø)
payload builder 8.32% <ø> (ø)
primitives 86.51% <ø> (-0.04%) ⬇️

Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add these to tests workflows too?

@tcoratger
Copy link
Contributor Author

Can we add these to tests workflows too?

@DaniPopes Yes sure, I've just extended, tell me if this is better or if you see other places with this should be set like that? For me this seems good like that, I've pushed the timeout to 60 minutes at the most critical places.

@DaniPopes
Copy link
Member

DaniPopes commented Sep 22, 2023

It's missing integration.yml I think then we're good
Also a tip @tcoratge use "resolve" or similar keywords so the issue gets automatically closed on merge: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

@tcoratger
Copy link
Contributor Author

It's missing integration.yml I think then we're good Also a tip @tcoratge use "resolve" or similar keywords so the issue gets automatically closed on merge: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

Done, thanks for the tip, I don't know why I was thinking that "solve" did the same job but I should have checked if the issues closed automatically...

@DaniPopes DaniPopes added this pull request to the merge queue Sep 22, 2023
Merged via the queue into paradigmxyz:main with commit 64aba9c Sep 22, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Changes in the contributor workflow and planning C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI jobs timeout
3 participants