Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing builder functions #4770

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 25, 2023

🤖 Generated by Copilot at 8c7ebd8

Add methods to configure reputation and backoff for peers. This is part of a refactor to make the PeerManagerConfig struct more flexible and customizable.

@mattsse mattsse added C-enhancement New feature or request A-networking Related to networking in general labels Sep 25, 2023
@mattsse mattsse force-pushed the matt/add-missing-reputation-weight branch from 8c7ebd8 to 0757513 Compare September 25, 2023 17:35
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #4770 (0757513) into main (0f9def0) will decrease coverage by 0.15%.
Report is 5 commits behind head on main.
The diff coverage is 85.71%.

Impacted file tree graph

Files Coverage Δ
crates/net/network/src/peers/manager.rs 83.40% <85.71%> (-0.85%) ⬇️

... and 80 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.50% <42.85%> (-0.05%) ⬇️
unit-tests 63.38% <85.71%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.07% <ø> (-0.04%) ⬇️
blockchain tree 83.69% <ø> (-0.05%) ⬇️
pipeline 88.53% <ø> (ø)
storage (db) 73.49% <ø> (-0.22%) ⬇️
trie 94.48% <ø> (-0.29%) ⬇️
txpool 49.51% <ø> (-0.48%) ⬇️
networking 76.82% <85.71%> (-0.30%) ⬇️
rpc 57.67% <ø> (-0.02%) ⬇️
consensus 62.84% <ø> (-0.26%) ⬇️
revm 28.33% <ø> (ø)
payload builder 8.20% <ø> (-0.12%) ⬇️
primitives 86.52% <ø> (-0.04%) ⬇️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rjected Rjected added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit 272f062 Sep 25, 2023
23 checks passed
@Rjected Rjected deleted the matt/add-missing-reputation-weight branch September 25, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Related to networking in general C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants