Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update genesis for holesky #4773

Merged
merged 2 commits into from
Sep 25, 2023
Merged

feat: update genesis for holesky #4773

merged 2 commits into from
Sep 25, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Sep 25, 2023

Updates the genesis holesky, using the genesis.json from:
https://github.com/eth-clients/holesky/blob/ea39b9006210848e13f28d92e12a30548cecd41d/custom_config_data/genesis.json

Updates the Paris fork_block docs to note that holesky uses mergeNetSplitBlock in its genesis.

Also updates the datadir resolution to use each named chain's to_string method, so additional testnets will not need special handling.

@Rjected Rjected added C-enhancement New feature or request A-cli Related to the reth CLI labels Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #4773 (ffe5ae1) into main (371388d) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 94.73%.

Impacted file tree graph

Files Coverage Δ
crates/primitives/src/chain/spec.rs 98.08% <100.00%> (ø)
bin/reth/src/dirs.rs 75.34% <93.33%> (+4.32%) ⬆️

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.51% <0.00%> (-0.01%) ⬇️
unit-tests 63.39% <94.73%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.23% <93.33%> (+0.15%) ⬆️
blockchain tree 83.69% <ø> (ø)
pipeline 88.53% <ø> (ø)
storage (db) 73.49% <ø> (ø)
trie 94.48% <ø> (ø)
txpool 49.51% <ø> (ø)
networking 76.85% <ø> (-0.09%) ⬇️
rpc 57.68% <ø> (+<0.01%) ⬆️
consensus 62.84% <ø> (ø)
revm 28.33% <ø> (ø)
payload builder 8.20% <ø> (ø)
primitives 86.52% <100.00%> (ø)

@mattsse mattsse added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit 1f33cb5 Sep 25, 2023
23 checks passed
@mattsse mattsse deleted the dan/use-new-holesky-genesis branch September 25, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants