Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): rm hashbrown dep #4861

Merged
merged 1 commit into from
Sep 29, 2023
Merged

chore(deps): rm hashbrown dep #4861

merged 1 commit into from
Sep 29, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 29, 2023

std HashSet is just hashbrown

@mattsse mattsse added the A-dependencies Pull requests or issues that are about dependencies label Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023 •
edited
Loading

Codecov Report

Merging #4861 (32680ee) into main (a046288) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

Files Coverage Δ
crates/revm/revm-inspectors/src/access_list.rs 50.00% <ø> (ø)

... and 11 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.52% <ø> (-0.02%) ⬇️
unit-tests 62.63% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.28% <ø> (ø)
blockchain tree 80.44% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 73.31% <ø> (ø)
trie 94.48% <ø> (-0.04%) ⬇️
txpool 49.03% <ø> (-0.48%) ⬇️
networking 76.46% <ø> (-0.04%) ⬇️
rpc 57.79% <ø> (ø)
consensus 61.06% <ø> (ø)
revm 28.53% <ø> (ø)
payload builder 8.16% <ø> (ø)
primitives 85.26% <ø> (-0.01%) ⬇️

Rjected
Rjected approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattsse mattsse added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit 702d04b Sep 29, 2023
24 checks passed
@mattsse mattsse deleted the matt/rm-hashbrown-from-insp branch September 29, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg

Assignees
No one assigned
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected