Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only accept rpc enveloped format for transactions in payload #4928

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Oct 5, 2023

This restricts the formatting for transactions from engine_newPayload, requiring them to be in the RPC "enveloped" format.

try_block_to_payload_v3 is renamed to block_to_payload_v3 because it does not return a Result.

@Rjected Rjected added C-docs An addition or correction to our documentation A-rpc Related to the RPC implementation A-consensus Related to the consensus engine A-utils Related to commonly used utilities labels Oct 5, 2023
@Rjected Rjected requested a review from mattsse as a code owner October 5, 2023 23:47
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #4928 (1e24d8a) into main (442f28a) will increase coverage by 0.17%.
Report is 6 commits behind head on main.
The diff coverage is 90.80%.

Impacted file tree graph

Files Coverage Δ
crates/primitives/src/transaction/mod.rs 75.31% <ø> (+0.34%) ⬆️
crates/primitives/src/transaction/pooled.rs 62.03% <ø> (ø)
crates/payload/builder/src/payload.rs 0.00% <0.00%> (ø)
crates/rpc/rpc-types-compat/src/engine/payload.rs 76.57% <92.94%> (+29.10%) ⬆️

... and 29 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.48% <2.29%> (-0.03%) ⬇️
unit-tests 62.97% <90.80%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 33.00% <ø> (-0.02%) ⬇️
blockchain tree 80.63% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 74.43% <ø> (ø)
trie 94.48% <ø> (-0.04%) ⬇️
txpool 48.52% <ø> (-0.86%) ⬇️
networking 76.23% <ø> (+0.10%) ⬆️
rpc 58.41% <92.94%> (+0.67%) ⬆️
consensus 63.01% <ø> (+1.96%) ⬆️
revm 28.47% <ø> (ø)
payload builder 8.15% <0.00%> (ø)
primitives 85.47% <ø> (+0.06%) ⬆️

@Rjected Rjected requested a review from gakonst as a code owner October 6, 2023 04:11
@gakonst gakonst added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit c825aaf Oct 6, 2023
23 checks passed
@gakonst gakonst deleted the dan/roundtrip-payload-to-block branch October 6, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Related to the consensus engine A-rpc Related to the RPC implementation A-utils Related to commonly used utilities C-docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants