Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builder style implementation for trace_call #5074

Merged
merged 6 commits into from
Oct 18, 2023
Merged

Builder style implementation for trace_call #5074

merged 6 commits into from
Oct 18, 2023

Conversation

supernovahs
Copy link
Contributor

Ref #5051

@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #5074 (5fb7447) into main (3adc627) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
crates/rpc/rpc-api/src/trace.rs 100.00% <ø> (ø)
crates/rpc/rpc/src/trace.rs 44.17% <0.00%> (+2.14%) ⬆️
crates/rpc/rpc-types/src/eth/trace/tracerequest.rs 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 17.06% <0.00%> (-0.03%) ⬇️
unit-tests 62.42% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.90% <ø> (ø)
blockchain tree 80.82% <ø> (ø)
pipeline 88.38% <ø> (ø)
storage (db) 74.64% <ø> (ø)
trie 94.96% <ø> (ø)
txpool 55.76% <ø> (+0.43%) ⬆️
networking 78.16% <ø> (-0.09%) ⬇️
rpc 58.41% <0.00%> (-0.09%) ⬇️
consensus 63.01% <ø> (ø)
revm 28.73% <ø> (ø)
payload builder 7.95% <ø> (ø)
primitives 86.43% <ø> (+<0.01%) ⬆️

mattsse
mattsse requested changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, great start,

a few nits and suggestions

crates/rpc/rpc-types/src/eth/trace/tracerequest.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-types/src/eth/trace/tracerequest.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-types/src/eth/trace/tracerequest.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-types/src/eth/trace/tracerequest.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-types/src/eth/trace/tracerequest.rs Show resolved Hide resolved
@mattsse mattsse added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Oct 18, 2023
mattsse
mattsse requested changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, last pedantic naming nit

crates/rpc/rpc-types/src/eth/trace/tracerequest.rs Outdated Show resolved Hide resolved
@mattsse mattsse added this pull request to the merge queue Oct 18, 2023
Merged via the queue into paradigmxyz:main with commit ae3914e Oct 18, 2023
23 checks passed
mattsse pushed a commit that referenced this pull request Nov 8, 2023
@supernovahs @mattsse
Builder style implementation for trace_call (#5074)
1075bc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supernovahs @mattsse