Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use block id for block receipts #5105

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 19, 2023

Closes #5084

switch to BlockId according to execution-api specs

@mattsse mattsse requested a review from Rjected as a code owner October 19, 2023 22:31
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation M-changelog This change should be included in the changelog labels Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #5105 (f28ab81) into main (5dd5555) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
crates/rpc/rpc-api/src/eth.rs 100.00% <ø> (ø)
crates/rpc/rpc/src/eth/api/block.rs 50.00% <0.00%> (ø)
crates/rpc/rpc/src/eth/api/server.rs 92.60% <0.00%> (+0.60%) ⬆️

... and 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 17.09% <0.00%> (+<0.01%) ⬆️
unit-tests 62.29% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.85% <ø> (ø)
blockchain tree 80.82% <ø> (ø)
pipeline 88.36% <ø> (ø)
storage (db) 74.64% <ø> (ø)
trie 94.96% <ø> (-0.04%) ⬇️
txpool 55.33% <ø> (ø)
networking 78.20% <ø> (+0.02%) ⬆️
rpc 58.48% <0.00%> (+0.01%) ⬆️
consensus 62.94% <ø> (-0.08%) ⬇️
revm 28.73% <ø> (ø)
payload builder 7.95% <ø> (ø)
primitives 85.85% <ø> (-0.03%) ⬇️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rjected Rjected added this pull request to the merge queue Oct 20, 2023
Merged via the queue into main with commit d3de32a Oct 20, 2023
23 checks passed
@Rjected Rjected deleted the matt/use-block-id-for-block-receipts branch October 20, 2023 03:39
mattsse added a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior M-changelog This change should be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth_getBlockReceipts should be able to support blockHash params
2 participants