feat(storage): database/transaction/cursor metrics

[shekhirin]

[codecov]

Codecov Report

Merging #5149 (4bb82f6) into main (4dc15c3) will increase coverage by 36.08%.
Report is 28 commits behind head on main.
The diff coverage is 85.83%.

❗ Current head 4bb82f6 differs from pull request most recent head 093710b. Consider uploading reports for the commit 093710b to get more accurate results

Files	Coverage Δ
crates/storage/db/src/implementation/mdbx/mod.rs	97.51% <100.00%> (+90.72%)	⬆️
crates/storage/db/src/lib.rs	53.94% <ø> (+38.15%)	⬆️
bin/reth/src/stage/run.rs	1.36% <0.00%> (+1.36%)	⬆️
crates/storage/db/src/abstraction/mock.rs	0.00% <0.00%> (ø)
crates/storage/db/src/metrics/listener.rs	90.90% <90.90%> (ø)
...rates/storage/db/src/implementation/mdbx/cursor.rs	83.66% <94.20%> (+42.59%)	⬆️
bin/reth/src/prometheus_exporter.rs	6.87% <68.75%> (+6.87%)	⬆️
crates/storage/db/src/implementation/mdbx/tx.rs	92.77% <89.47%> (+14.88%)	⬆️
bin/reth/src/node/mod.rs	29.96% <59.37%> (-33.61%)	⬇️
crates/storage/db/src/metrics/mod.rs	84.52% <84.52%> (ø)

... and 476 files with indirect coverage changes

Flag	Coverage Δ
integration-tests	?
unit-tests	62.15% <85.83%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
reth binary	29.96% <61.22%> (+4.18%)	⬆️
blockchain tree	80.82% <ø> (+52.36%)	⬆️
pipeline	88.26% <ø> (+83.21%)	⬆️
storage (db)	70.82% <89.89%> (+40.84%)	⬆️
trie	94.93% <ø> (+72.39%)	⬆️
txpool	45.41% <ø> (+4.03%)	⬆️
networking	71.25% <ø> (+40.35%)	⬆️
rpc	40.89% <ø> (+14.41%)	⬆️
consensus	62.95% <ø> (+37.88%)	⬆️
revm	23.36% <ø> (+13.51%)	⬆️
payload builder	3.39% <ø> (-10.77%)	⬇️
primitives	81.34% <ø> (+52.17%)	⬆️

[mattsse]

hmm, what's the motivation for using a channel for metrics updates? I guess for more sophisticated reporting that requires more work than just increasing or decreasing metric values like histograms etc?

[mattsse]

this looks great!

would love to see some additional docs for the new metrics type, otherwise lgtm

[mattsse]

changes lgtm

not sure about the operation specific metrics