Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Optimism unit / integration tests #5318

Merged
merged 4 commits into from
Nov 6, 2023
Merged

fix(ci): Optimism unit / integration tests #5318

merged 4 commits into from
Nov 6, 2023

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Nov 5, 2023 •
edited
Loading

Overview

Fixes the CI such that unit / integration tests run when the optimism feature flag is enabled.

Also fixes some tests added in #5317 that were failing to compile, plus removed a size test for the TxDeposit type w/ an incorrect impl.

refcell
refcell reviewed Nov 5, 2023
View reviewed changes
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution

@clabby
Copy link
Collaborator Author

clabby commented Nov 5, 2023 •
edited
Loading

AFK - will fix the integration test after I'm back at my desk. Don't merge for now.

@clabby clabby marked this pull request as ready for review November 5, 2023 21:48
@clabby clabby marked this pull request as draft November 5, 2023 22:41
@clabby clabby marked this pull request as ready for review November 6, 2023 12:21
@mattsse mattsse added this pull request to the merge queue Nov 6, 2023
Merged via the queue into paradigmxyz:main with commit fa803fd Nov 6, 2023
25 checks passed
mattsse pushed a commit that referenced this pull request Nov 8, 2023
@clabby @mattsse
fix(ci): Optimism unit / integration tests (#5318)
cd409b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell left review comments

@DaniPopes DaniPopes DaniPopes approved these changes

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clabby @mattsse @refcell @DaniPopes