Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(state): split_at refactor #5419

Merged
merged 2 commits into from
Nov 14, 2023
Merged

chore(state): split_at refactor #5419

merged 2 commits into from
Nov 14, 2023

Conversation

rkrasiuk
Copy link
Member

Description

Refactor and change the logic of BundleStateWithReceipts::split_at method to resemble the behavior of std split_at methods.

Replaces #5233

@rkrasiuk rkrasiuk added C-debt Refactor of code section that is hard to understand or maintain A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Nov 13, 2023
@rkrasiuk rkrasiuk mentioned this pull request Nov 13, 2023
Closed
mattsse
mattsse approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@mattsse mattsse added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit 2bd8c7e Nov 14, 2023
25 checks passed
@mattsse mattsse deleted the rkrasiuk/state-split-at branch November 14, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @mattsse