Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(downloader): replace database with header provider #5472

Merged
merged 3 commits into from
Nov 18, 2023
Merged

chore(downloader): replace database with header provider #5472

merged 3 commits into from
Nov 18, 2023

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Nov 17, 2023 •
edited
Loading

Description

Builds on top of #5470.
Replaces generic Database with HeaderProvider.

@rkrasiuk rkrasiuk added C-debt Refactor of code section that is hard to understand or maintain A-downloaders Related to headers/bodies downloaders labels Nov 17, 2023
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/replace-bodies-dl-provider branch from 5d04bc2 to 2651c8e Compare November 17, 2023 15:30
@rkrasiuk rkrasiuk marked this pull request as ready for review November 17, 2023 19:39
mattsse
mattsse approved these changes Nov 18, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice,

needs rebase

@rkrasiuk rkrasiuk force-pushed the rkrasiuk/replace-bodies-dl-provider branch from 7585ed3 to d8984cf Compare November 18, 2023 08:08
@rkrasiuk rkrasiuk added this pull request to the merge queue Nov 18, 2023
Merged via the queue into main with commit d05dda7 Nov 18, 2023
26 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/replace-bodies-dl-provider branch November 18, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-downloaders Related to headers/bodies downloaders C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @mattsse