feat: get rid of lifetime GATs #5478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
reviewed
Nov 17, 2023
mattsse
changed the title
mattsse
requested review from
joshieDo,
shekhirin,
rkrasiuk,
Rjected,
rakita,
onbjerg and
gakonst
as code owners
mattsse
added
the
C-debt
DaniPopes
requested changes
Nov 18, 2023
mattsse
force-pushed
the
matt/remove-lifetime-gats
branch
from
bb4a972
to
382ca11
Compare
DaniPopes
approved these changes
Nov 18, 2023
rkrasiuk
approved these changes
Nov 19, 2023
Comment on lines
+26
to
+32
| /// Sealed trait to limit the implementors of the Database trait. | ||
| pub trait Sealed: Sized {} | ||
| #[allow(missing_debug_implementations)] | ||
| pub struct Bounds<T>(T); | ||
| impl<T> Sealed for Bounds<T> {} | ||
|
|
||
| impl<DB: Database> Sealed for &DB {} | ||
| impl<DB: Database> Sealed for Arc<DB> {} | ||
| impl Sealed for DatabaseEnv {} | ||
| impl Sealed for DatabaseMock {} |
There was a problem hiding this comment.
just to retain total control, but can be removed imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked by #5476collapsed GAT traits into the traits that inherited those