fix: track actually requested transactions #5483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
added
C-bug
rkrasiuk
reviewed
Nov 18, 2023
| @@ -857,7 +856,7 @@ where | |||
| // known that this transaction is bad. (e.g. consensus | |||
| // rules) | |||
| if err.is_bad_transaction() && !this.network.is_syncing() { | |||
| trace!(target: "net::tx", ?err, "Bad transaction import"); | |||
| trace!(target: "net::tx", ?err, "bad pool transaction import"); | |||
There was a problem hiding this comment.
can we output tx hash here as well? it would help us inspect them in case we have false positives
There was a problem hiding this comment.
this is already part of the error:
reth/crates/transaction-pool/src/error.rs
Line 29 in d08480a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes an issue where the tracked
requested_hashesweren't set properly.this previously collected the hashes from the response instead.
this could result in unbounded mem growth