feat(op-reth): Canyon transition create2Deployer force deployment
#5527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
force-pushed
the
cl/op/canyon-hf-create2-deployer
branch
4 times, most recently
from
0535c78
to
a77682d
Compare
clabby
force-pushed
the
cl/op/canyon-hf-receipts-version
branch
from
467b722
to
1f8252d
Compare
clabby
force-pushed
the
cl/op/canyon-hf-create2-deployer
branch
from
a77682d
to
1797497
Compare
clabby
force-pushed
the
cl/op/canyon-hf-receipts-version
branch
from
1f8252d
to
4149bb2
Compare
clabby
force-pushed
the
cl/op/canyon-hf-create2-deployer
branch
from
1797497
to
062e6dc
Compare
clabby
force-pushed
the
cl/op/canyon-hf-receipts-version
branch
from
4149bb2
to
13b7346
Compare
clabby
force-pushed
the
cl/op/canyon-hf-create2-deployer
branch
from
062e6dc
to
bc8ecc9
Compare
rkrasiuk
requested changes
Nov 23, 2023
Comment on lines
+72
to
+77
| super::ensure_create2_deployer(self.chain_spec().clone(), block.timestamp, self.db_mut()) | ||
| .map_err(|_| BlockExecutionError::ProviderError)?; |
There was a problem hiding this comment.
if the fork block ends up being empty, than the create2 deployer will never be committed because of an early return few lines above
There was a problem hiding this comment.
Thankfully this should never be possible :)
Optimism blocks will always have at least one transaction, which is the L1 info transaction sent by the system. Added a clarifying comment.
clabby
force-pushed
the
cl/op/canyon-hf-create2-deployer
branch
from
bc8ecc9
to
fd40cc7
Compare
clabby
force-pushed
the
cl/op/canyon-hf-receipts-version
branch
2 times, most recently
from
21cf8be
to
f8ba976
Compare
clabby
force-pushed
the
cl/op/canyon-hf-create2-deployer
branch
from
fd40cc7
to
2967963
Compare
clabby
force-pushed
the
cl/op/canyon-hf-receipts-version
branch
from
f8ba976
to
8efaf95
Compare
clabby
force-pushed
the
cl/op/canyon-hf-create2-deployer
branch
from
2967963
to
9c4f473
Compare
clabby
force-pushed
the
cl/op/canyon-hf-receipts-version
branch
from
8efaf95
to
1ace0ff
Compare
clabby
force-pushed
the
cl/op/canyon-hf-create2-deployer
branch
from
9c4f473
to
430a6e4
Compare
clabby
force-pushed
the
cl/op/canyon-hf-receipts-version
branch
from
1ace0ff
to
0b88100
Compare
clabby
force-pushed
the
cl/op/canyon-hf-create2-deployer
branch
from
430a6e4
to
dbcc15c
Compare
clabby
force-pushed
the
cl/op/canyon-hf-create2-deployer
branch
from
c92ad68
to
7c53455
Compare
clippy
clabby
force-pushed
the
cl/op/canyon-hf-receipts-version
branch
from
26a7455
to
7cef5ee
Compare
clabby
force-pushed
the
cl/op/canyon-hf-create2-deployer
branch
from
7c53455
to
8c30c41
Compare
clabby
force-pushed
the
cl/op/canyon-hf-create2-deployer
branch
from
8c30c41
to
99aadf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a force deployment of the
create2deployercontract in the superchain registry upon the Canyon transition.Reference: https://github.com/ethereum-optimism/op-geth/blob/cf19c1e39c326a806df1096c45e3f2fbcd5ca00c/consensus/misc/create2deployer.go