-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reth-ethereum-forks crate #5621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great
I'd like to reexport everything in reth-primitives so we don't have to update all imports across the codebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs a cleanup, we probably need way less dependencies
Committed requested changes
import changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, this just needs a bit more cleanup
Remove unnecessary dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great!
ty
Resolving issue #5524
Created reth-ethereum-forks crate. Flipped fork_id and fork_filter methods to make them methods defined on ChainSpec instead of Hardfork. The new methods are called hardfork_fork_id and hardfork_fork_filter since fork_id and fork_filter methods with different arguments are already defined for ChainSpec.
Fork Id:
Fork Filter: