Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: apply same impl order #5639

Merged
merged 1 commit into from
Nov 30, 2023
Merged

chore: apply same impl order #5639

merged 1 commit into from
Nov 30, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 30, 2023

triggered by warning

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Nov 30, 2023
DaniPopes
DaniPopes approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most readable reorder diff

@mattsse
Copy link
Collaborator Author

mattsse commented Nov 30, 2023

yeah this looks bad -.-

but I trust the auto-fix

@mattsse mattsse added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit 02a07f6 Nov 30, 2023
27 checks passed
@mattsse mattsse deleted the matt/apply-same-order branch November 30, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @DaniPopes