Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Default for RpcServerArgs #5646

Merged
merged 2 commits into from
Dec 1, 2023
Merged

feat: add Default for RpcServerArgs #5646

merged 2 commits into from
Dec 1, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Dec 1, 2023

Adds a Default implementation for RpcServerArgs, and adds a From impl in the zero_as_none macro

@Rjected Rjected added C-enhancement New feature or request A-cli Related to the reth CLI labels Dec 1, 2023
@Rjected Rjected requested a review from onbjerg as a code owner December 1, 2023 05:20
mattsse
mattsse approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit 4a0497d Dec 1, 2023
27 checks passed
@mattsse mattsse deleted the dan/default-rpc-server-args branch December 1, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @mattsse