Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(evm): use provider errors #5649

Merged
merged 1 commit into from
Dec 1, 2023
Merged

chore(evm): use provider errors #5649

merged 1 commit into from
Dec 1, 2023

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Dec 1, 2023

Description

Final boss for getting rid of tedious RethError everywhere.

  • Replace RethError on StateProvider implementations with ProviderError
  • Replace RethError in relevant execution error types
  • Replace optimism RethError::Custom instances with concrete error variants

@rkrasiuk rkrasiuk added C-debt Refactor of code section that is hard to understand or maintain A-execution Related to the Execution and EVM labels Dec 1, 2023
mattsse
mattsse approved these changes Dec 1, 2023
View reviewed changes
crates/revm/src/processor.rs
@@ -53,7 +52,7 @@ pub struct EVMProcessor<'a> {
/// The configured chain-spec
pub(crate) chain_spec: Arc<ChainSpec>,
/// revm instance that contains database and env environment.
pub(crate) evm: EVM<StateDBBox<'a, RethError>>,
pub(crate) evm: EVM<StateDBBox<'a, ProviderError>>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, do we still need the lifetime here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might not need it anymore, need to try removing it from revm

@rkrasiuk rkrasiuk added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit 67d93e8 Dec 1, 2023
27 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/chore-evm-provider-error branch December 1, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-execution Related to the Execution and EVM C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @mattsse