Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ethereum-fork) : enhance Head struct with methods #5656

Merged
merged 8 commits into from
Dec 5, 2023
Merged

feat(ethereum-fork) : enhance Head struct with methods #5656

merged 8 commits into from
Dec 5, 2023

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

Enhanced the Head struct by adding new methods for creation, updating, and data retrieval.

Rjected
Rjected reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial comments

crates/ethereum-forks/src/head.rs Outdated Show resolved Hide resolved
Rjected
Rjected approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@Rjected Rjected added this pull request to the merge queue Dec 5, 2023
Merged via the queue into paradigmxyz:main with commit dc56078 Dec 5, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DoTheBestToGetTheBest @Rjected