Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct error if fault fn missing #5688

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix: use correct error if fault fn missing #5688

merged 1 commit into from
Dec 4, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 4, 2023

ref #5684

we already had the error variant but weren't using it

@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Dec 4, 2023
@mattsse mattsse added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit a3ca958 Dec 4, 2023
27 checks passed
@mattsse mattsse deleted the matt/use-correct-error branch December 4, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@shekhirin shekhirin Awaiting requested review from shekhirin

@Rjected Rjected Awaiting requested review from Rjected

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @DaniPopes